improve(diskclaim): only record disk claim events when disk is Available #1260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The scenario that troubles users is generally a disk they believe is available, that is, a disk in an Available state. If all the disk information is added to the event, it will make the event very long. Signed-off-by: SSmallMonster <mingming.zhou@daocloud.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The scenario that troubles users is generally a disk they believe is available, that is, a disk in an Available state. If all the disk information is added to the event, it will make the event very long.
relevant issue: #1218
Special notes for your reviewer:
Warning LocalDiskClaimAssignFail 18s (x12 over 28s) localdiskclaim-controller Assign free disk fail, due to error: there is no available disk assigned to 172-30-46-11-hdd-claim Warning LocalDiskClaimAssignFail 18s (x6 over 28s) localdiskclaim-controller localdisk-e98be39ca068dd7877b021e47c8e712b are LocalDiskOwnerUnMatch;localdisk-90a3849907d060920639f7ce16c6c4f0,localdisk-647045e3018fa21e22f3d96d049c87ad are LocalDiskHasReservedDoes this PR introduce a user-facing change?