fix(apiserver): fix StorageNodePoolDiskGet get localdisk from a wrong path #1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1275 +/- ##
=======================================
Coverage 36.47% 36.47%
=======================================
Files 28 28
Lines 2218 2218
=======================================
Hits 809 809
Misses 1306 1306
Partials 103 103 ☔ View full report in Codecov by Sentry. |
|
can you have a look? @peng9808 |
|
lgtm |
hikariwo
force-pushed
the
fix-StorageNodePoolDiskGet
branch
from
cfe75b8
to
02aac0c
Compare
pkg/apiserver/manager/hwameistor/localstoragenode_controller.go
Outdated
Show resolved
Hide resolved
Signed-off-by: lancerxiu <1377004871@qq.com>
hikariwo
force-pushed
the
fix-StorageNodePoolDiskGet
branch
from
02aac0c
to
d04f355
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
fix StorageNodePoolDiskGet getting localdisk from wrong disk information
FYI: #1188
Special notes for your reviewer:
Does this PR introduce a user-facing change?