Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[unit-test]add smartctl command result example #1288

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

hikariwo
Copy link
Member

What this PR does / why we need it:

add smartctl command result example, make the smart device struct understand easier

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Signed-off-by: lancerxiu <1377004871@qq.com>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (21e63bf) 36.65% compared to head (9887739) 36.65%.
Report is 11 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1288   +/-   ##
=======================================
  Coverage   36.65%   36.65%           
=======================================
  Files          28       28           
  Lines        2218     2218           
=======================================
  Hits          813      813           
  Misses       1302     1302           
  Partials      103      103           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SSmallMonster SSmallMonster added the kind/unit-test Issues or PRs related to refactoring the hwameistor unit test label Nov 30, 2023
@hikariwo
Copy link
Member Author

hikariwo commented Dec 4, 2023

@peng9808 can you have a look?

@peng9808
Copy link
Collaborator

peng9808 commented Dec 4, 2023

lgtm

@SSmallMonster SSmallMonster merged commit 11803a7 into hwameistor:main Dec 5, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/unit-test Issues or PRs related to refactoring the hwameistor unit test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants