Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug pending when pruning replica for localvolumemigrate #1290

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

buffalo1024
Copy link
Contributor

What this PR does / why we need it:

if LocalVolume is convertible, ConfigMap will not be created for localvolumemigrate, so we should not check ConfigMap when pruning replica

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Signed-off-by: buffalo1024 <yikaichen@yikaichendeMacBook-Pro.local>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (21e63bf) 36.65% compared to head (d5e4772) 36.65%.
Report is 11 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1290   +/-   ##
=======================================
  Coverage   36.65%   36.65%           
=======================================
  Files          28       28           
  Lines        2218     2218           
=======================================
  Hits          813      813           
  Misses       1302     1302           
  Partials      103      103           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@SSmallMonster SSmallMonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SSmallMonster SSmallMonster added the kind/bug Categorizes issue or PR as related to a bug. label Nov 30, 2023
@SSmallMonster SSmallMonster merged commit ff761b8 into hwameistor:main Nov 30, 2023
3 checks passed
@buffalo1024 buffalo1024 linked an issue Dec 3, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lvmigrate stuck on PruneReplica
3 participants