change client type for supporting fake client to test #1292
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The origin type
*clientset.Clientset
is a subclass ofclientset.Interface
and*clientset.Clientset
is not supported to use a fake client to test.It may cause further development more hard. So I suppose to modify it to an Interface type,for further testing and development.hwameistor/pkg/local-disk-manager/builder/localdisknode/Kubernetes.go
Lines 15 to 17 in 138f245
Special notes for your reviewer:
Does this PR introduce a user-facing change?