Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change client type for supporting fake client to test #1292

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

hikariwo
Copy link
Member

@hikariwo hikariwo commented Nov 30, 2023

What this PR does / why we need it:

The origin type *clientset.Clientset is a subclass of clientset.Interface and *clientset.Clientset is not supported to use a fake client to test.It may cause further development more hard. So I suppose to modify it to an Interface type,for further testing and development.

type Kubeclient struct {
// clientset
clientset *clientset.Clientset

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Signed-off-by: lancerxiu <1377004871@qq.com>
@codecov-commenter
Copy link

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (21e63bf) 36.65% compared to head (475b420) 36.58%.
Report is 15 commits behind head on main.

Files Patch % Lines
...l-disk-manager/builder/localdisknode/Kubernetes.go 0.00% 2 Missing ⚠️
...disk-manager/builder/localdiskvolume/Kubernetes.go 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1292      +/-   ##
==========================================
- Coverage   36.65%   36.58%   -0.07%     
==========================================
  Files          28       28              
  Lines        2218     2222       +4     
==========================================
  Hits          813      813              
- Misses       1302     1306       +4     
  Partials      103      103              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SSmallMonster SSmallMonster added the kind/enhancement New feature or request label Dec 1, 2023
@SSmallMonster SSmallMonster merged commit 47b26df into hwameistor:main Dec 1, 2023
3 checks passed
@hikariwo hikariwo deleted the add-test-support branch December 1, 2023 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants