Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[unit-test] add more localdisknode test #1293

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

hikariwo
Copy link
Member

@hikariwo hikariwo commented Dec 1, 2023

What this PR does / why we need it:

add more localdisknode test

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Signed-off-by: lancerxiu <1377004871@qq.com>
@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (21e63bf) 36.65% compared to head (1a6f42f) 37.08%.
Report is 17 commits behind head on main.

Files Patch % Lines
...disk-manager/builder/localdiskvolume/Kubernetes.go 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1293      +/-   ##
==========================================
+ Coverage   36.65%   37.08%   +0.42%     
==========================================
  Files          28       28              
  Lines        2218     2222       +4     
==========================================
+ Hits          813      824      +11     
+ Misses       1302     1294       -8     
- Partials      103      104       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hikariwo hikariwo changed the title add more localdisknode test [unit-test] add more localdisknode test Dec 1, 2023
@hikariwo
Copy link
Member Author

hikariwo commented Dec 4, 2023

@peng9808 can you have a look?

@peng9808
Copy link
Collaborator

peng9808 commented Dec 4, 2023

lgtm

@SSmallMonster SSmallMonster merged commit 187ffcc into hwameistor:main Dec 5, 2023
3 checks passed
@SSmallMonster SSmallMonster added the kind/unit-test Issues or PRs related to refactoring the hwameistor unit test label Dec 5, 2023
@hikariwo hikariwo deleted the add-ldn-test branch December 5, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/unit-test Issues or PRs related to refactoring the hwameistor unit test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants