Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pool disk show bug #1308

Merged
merged 1 commit into from
Dec 12, 2023
Merged

fix pool disk show bug #1308

merged 1 commit into from
Dec 12, 2023

Conversation

peng9808
Copy link
Collaborator

@peng9808 peng9808 commented Dec 7, 2023

fix pool disk show bug

What this PR does / why we need it:

The pool display filters out unused disks

Special notes for your reviewer:

NONE

Does this PR introduce a user-facing change?

NONE


@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a1ef97d) 36.58% compared to head (1199ccb) 28.41%.
Report is 10 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1308      +/-   ##
==========================================
- Coverage   36.58%   28.41%   -8.18%     
==========================================
  Files          28       34       +6     
  Lines        2222     3079     +857     
==========================================
+ Hits          813      875      +62     
- Misses       1306     2089     +783     
- Partials      103      115      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hikariwo
Copy link
Member

hikariwo commented Dec 7, 2023

lgtm

@windsonsea windsonsea changed the title Signed-off-by: peng9808 <peng.lai@daocloud.io> fix pool disk show bug Dec 7, 2023
@SSmallMonster SSmallMonster added the kind/bug Categorizes issue or PR as related to a bug. label Dec 12, 2023
@SSmallMonster SSmallMonster merged commit b01c78b into hwameistor:main Dec 12, 2023
3 checks passed
@peng9808 peng9808 deleted the fixListLocalStorageNode branch December 25, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants