fix(csi-volume): fix volume leaks when user delete pvc but pv not created #1316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SSmallMonster
added
kind/bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1316 +/- ##
==========================================
- Coverage 28.41% 28.35% -0.07%
==========================================
Files 34 34
Lines 3079 3079
==========================================
- Hits 875 873 -2
- Misses 2089 2090 +1
- Partials 115 116 +1 ☔ View full report in Codecov by Sentry. |
refer to https://github.com/container-storage-interface/spec/blob/master/spec.md#error-scheme plugin should return the correct status to tell co what to do next when CreateVolume failed at first time. When Unavailable status code returnd, co will retry create volume and store this process at cache. This also helps co to call DeleteVolume as expected when user delete pvc when pv not created but backend volume has created. Signed-off-by: SSmallMonster <mingming.zhou@daocloud.io>
SSmallMonster
force-pushed
the
fix-volume-leak
branch
from
7ace549
to
5a8dbde
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Special notes for your reviewer:
fix #1306
refer to https://github.com/container-storage-interface/spec/blob/master/spec.md#error-scheme, plugin should return the correct status to tell co what to do next when
CreateVolumefailed at first time. When Unavailable status code returnd, co will retry create volume and store this process at cache.This also helps co to call
DeleteVolumeas expected when user delete pvc when pv not createdbut backend volume has created.
Does this PR introduce a user-facing change?