Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add VolumeSnapshotClass #1325

Merged
merged 2 commits into from
Dec 25, 2023
Merged

add VolumeSnapshotClass #1325

merged 2 commits into from
Dec 25, 2023

Conversation

peng9808
Copy link
Collaborator

What this PR does / why we need it:

add VolumeSnapshotClass ctl

Special notes for your reviewer:

NONE

Does this PR introduce a user-facing change?

NONE

@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1f638d5) 27.74% compared to head (d5fc2fa) 28.74%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1325      +/-   ##
==========================================
+ Coverage   27.74%   28.74%   +1.00%     
==========================================
  Files          34       34              
  Lines        3767     3079     -688     
==========================================
- Hits         1045      885     -160     
+ Misses       2605     2077     -528     
  Partials      117      117              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: peng9808 <peng.lai@daocloud.io>
@SSmallMonster SSmallMonster added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 22, 2023
Copy link
Member

@SSmallMonster SSmallMonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits

@SSmallMonster SSmallMonster merged commit 51afbd5 into hwameistor:main Dec 25, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants