Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve(apiserver):check localdisk exist before using #1339

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

hikariwo
Copy link
Member

What this PR does / why we need it:

check localdisk exist before using

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Signed-off-by: lancerxiu <1377004871@qq.com>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4d8e24b) 28.74% compared to head (b0b44ff) 28.74%.
Report is 27 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1339   +/-   ##
=======================================
  Coverage   28.74%   28.74%           
=======================================
  Files          34       34           
  Lines        3079     3079           
=======================================
  Hits          885      885           
  Misses       2077     2077           
  Partials      117      117           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hikariwo
Copy link
Member Author

@peng9808 can you have a look?

@SSmallMonster SSmallMonster added the kind/enhancement New feature or request label Dec 27, 2023
@peng9808
Copy link
Collaborator

lgtm

@SSmallMonster SSmallMonster merged commit 8da97ab into hwameistor:main Jan 2, 2024
3 checks passed
@hikariwo hikariwo deleted the check-ld-length branch January 2, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants