Fix uninitialized EventRecorder #1427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
I've observed that in the pkg/apiserver/manager/manager.go file, instances of EventRecorder are declared for various controller factory methods but are not properly initialized. Although the current codebase does not actively use these EventRecorder instances, if any future modifications attempt to use them, this could lead to runtime panic due to nil pointer dereference. This uninitialized usage poses a risk for potential runtime errors, which could affect the stability of the application.
#1420
Special notes for your reviewer:
Does this PR introduce a user-facing change?