Use syscall instead of df to gather volume stats #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #953 +/- ##
=======================================
Coverage 29.80% 29.80%
=======================================
Files 24 24
Lines 1570 1570
=======================================
Hits 468 468
Misses 1040 1040
Partials 62 62 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Luca Kröger <l.kroeger01@gmail.com>
sun7927
reviewed
Jul 3, 2023
| if len(line) == 0 { | ||
| continue | ||
| } | ||
| err := syscall.Statfs(mntPoint, &stats) |
There was a problem hiding this comment.
This 'syscall' will be executed inside the local-storage container, and will not get the expected result. Actually, the command should be executed on the OS which is outside of the container, that's why it is executed by nsexecutor.
In addition, did you test your change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR moves checking the volume stats (inodes, available blocks, etc) to a syscall - making it more resilient to changes in output due to different OSes and their df implementations. It also enables stats to work on systems which do not have df installed like Talos Linux
Special notes for your reviewer:
Does this PR introduce a user-facing change?