(OpenAI) Add model_name to LLMResult.llm_output #1713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariokostelac
force-pushed
the
mk/model_name_in_llm_output
branch
from
3f3b326
to
a8a6e83
Compare
Given that different models have very different latencies and pricings, it's benefitial to pass the information about the model that generated the response. Such information allows implementing custom callback managers and track usage and price per model. Addresses langchain-ai#1557.
mariokostelac
force-pushed
the
mk/model_name_in_llm_output
branch
from
a8a6e83
to
48b0685
Compare
bdonkey
added a commit
to bdonkey/langchain
that referenced
this pull request
Mar 23, 2023
* master: (68 commits) hotfix (langchain-ai#1742) Harrison/move docs (langchain-ai#1741) move docs (langchain-ai#1740) bump version to 114 (langchain-ai#1739) Harrison/latex splitter (langchain-ai#1738) Harrison/blackboard loader (langchain-ai#1737) docs: add docs link to agent toolkits (langchain-ai#1735) fix: agent json parser fails with text in suffix (langchain-ai#1734) Harrison/official method (langchain-ai#1728) Sagemaker Endpoint LLM (langchain-ai#1686) adding new agent types in comments (langchain-ai#1711) (OpenAI) Add model_name to LLMResult.llm_output (langchain-ai#1713) Fix all the bug in init Tool in docs (langchain-ai#1725) Bump duckdb-engine to 0.7.0 (langchain-ai#1726) Add HTML document_loader that includes page title metadata (langchain-ai#1720) fix async in agent (langchain-ai#1723) pydantic/json parsing (langchain-ai#1722) Loosen PyYAML dependency (langchain-ai#1698) Adding ability to `return_pl_id` to all PromptLayer Models in LangChain (langchain-ai#1699) fallback to {} for None metadata from Chroma (langchain-ai#1714) ...
mariokostelac
pushed a commit
to mariokostelac/langchain
that referenced
this pull request
Mar 24, 2023
This makes sure OpenAI and ChatOpenAI have the same llm_output, and allow tracking usage per model. Same work for OpenAI was done in langchain-ai#1713.
hwchase17
pushed a commit
that referenced
this pull request
Mar 24, 2023
This makes sure OpenAI and ChatOpenAI have the same llm_output, and allow tracking usage per model. Same work for OpenAI was done in #1713.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that different models have very different latencies and pricings, it's benefitial to pass the information about the model that generated the response. Such information allows implementing custom callback managers and track usage and price per model.
Addresses #1557.