Change Default GoogleDriveLoader Behavior to not Load Trashed Files (issue #5104) #5220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
This was referenced Jun 15, 2023
hwchase17
pushed a commit
that referenced
this pull request
Jun 19, 2023
# Iterate through filtered file types instead of all listed files Fixes #6257 #4926 originally added the functionality to filter by file type, storing the filtered files in `_files` #5220 removed the functionality when adding code to filter trashed files by using the `files` variables instead of the `_files` variable. This PR simply adds the functionality back by using `_files` again. #### Who can review? @hwchase17 - project lead @eyurtsev
Undertone0809
pushed a commit
to Undertone0809/langchain
that referenced
this pull request
Jun 19, 2023
…issue langchain-ai#5104) (langchain-ai#5220) # Change Default GoogleDriveLoader Behavior to not Load Trashed Files (issue langchain-ai#5104) Fixes langchain-ai#5104 If the previous behavior of loading files that used to live in the folder, but are now trashed, you can use the `load_trashed_files` parameter: ``` loader = GoogleDriveLoader( folder_id="1yucgL9WGgWZdM1TOuKkeghlPizuzMYb5", recursive=False, load_trashed_files=True ) ``` As not loading trashed files should be expected behavior, should we 1. even provide the `load_trashed_files` parameter? 2. add documentation? Feels most users will stick with default behavior ## Who can review? Community members can review the PR once tests pass. Tag maintainers/contributors who might be interested: DataLoaders - @eyurtsev Twitter: [@nicholasliu77](https://twitter.com/nicholasliu77)
kacperlukawski
pushed a commit
to kacperlukawski/langchain
that referenced
this pull request
Jun 29, 2023
…chain-ai#6258) # Iterate through filtered file types instead of all listed files Fixes langchain-ai#6257 langchain-ai#4926 originally added the functionality to filter by file type, storing the filtered files in `_files` langchain-ai#5220 removed the functionality when adding code to filter trashed files by using the `files` variables instead of the `_files` variable. This PR simply adds the functionality back by using `_files` again. #### Who can review? @hwchase17 - project lead @eyurtsev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Default GoogleDriveLoader Behavior to not Load Trashed Files (issue #5104)
Fixes #5104
If the previous behavior of loading files that used to live in the folder, but are now trashed, you can use the
load_trashed_filesparameter:As not loading trashed files should be expected behavior, should we
load_trashed_filesparameter?Who can review?
Community members can review the PR once tests pass. Tag maintainers/contributors who might be interested:
DataLoaders
Twitter: @nicholasliu77