Added unlock_all method #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
complexspaces
approved these changes
May 13, 2024
|
Thank you for the PR! I rebased your branch on the latest master so CI could run again. I'm hoping to have this out in a release shortly. |
|
This is now published as v3.1.0 on crates.io. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR adds a new method to async
SecretServiceand its blocking counterpart.Motivation - some secret service implementations such as KeePassXc have a security setting that enables interactive unlocking by showing a notification that must be manually confirmed on unlock. With it set, when this crate is used to search for 10 secrets and unlock them in a loop via
item.unlock()this leads to 10 interactive notifications. This PR makes it possible to unlock several secrets with a single interactive notification.