Fix parsing OAuth1.0a responses for Twitter #1821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjerdo
force-pushed
the
bugfix/twitter-oauth-response-parsing
branch
from
98fe4c4
to
cfed611
Compare
|
As you mentioned it's specific for Twitter and seems to not be used by other providers, thus I'm not sure this should be implemented as global... yet the global fallback was there before... Let me think a bit about this. |
|
Just checked the OAuth 1.0 implementation for Bitbucket: Response content should also be parsed with parse_str |
|
Sounds good, can you adjust Bitbucket & squash commits? Thanks 🙏 |
Parses text/html;charset=utf-8 response as string instead of json. This is necessary for OAuth1.0a responses from Twitter.
sjerdo
force-pushed
the
bugfix/twitter-oauth-response-parsing
branch
from
233e500
to
f2c9290
Compare
|
Thanks @sjerdo ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1820
Parses text/html;charset=utf-8 response as string instead of json. This is necessary for OAuth1.0a responses from Twitter.