Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oauth token of the same class will be created. fix in tests #1849

Merged
merged 1 commit into from Dec 13, 2021

Conversation

gassan
Copy link
Contributor

@gassan gassan commented Dec 12, 2021

Like in OAuthAuthenticator token of the same class will be created.
fix in tests - i think legacy authenticator will have all 5.4.x versions.

@gassan gassan force-pushed the recreate-token-of-the-same-class branch from 62f75e3 to 5d9517a Compare December 12, 2021 18:53
@gassan
Copy link
Contributor Author

gassan commented Dec 12, 2021

as usual squashed to 1 commit

Copy link
Collaborator

@stloyd stloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@stloyd stloyd merged commit 4558766 into hwi:master Dec 13, 2021
@stloyd
Copy link
Collaborator

stloyd commented Dec 13, 2021

Thank you @gassan !

@gassan gassan deleted the recreate-token-of-the-same-class branch December 23, 2021 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants