Review: Removed/replaced redundant parameter $firewallNames in Controllers #1861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XWB
reviewed
Dec 22, 2021
XWB
reviewed
Dec 22, 2021
gassan
force-pushed
the
redundant-firewall-names-arg
branch
from
110ee6b
to
f34c980
Compare
|
both functions are renamed. |
stloyd
requested changes
Dec 22, 2021
stloyd
requested changes
Dec 23, 2021
… the keys in ResourceOwnerMapLocator
gassan
force-pushed
the
redundant-firewall-names-arg
branch
from
c725469
to
328bd08
Compare
|
Done. Fill free to improve the changelog record. |
stloyd
approved these changes
Dec 23, 2021
|
Looks good, thanks @gassan ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two controllers have this parameter in their constructor, although they can be found in $resourceOwnerMapLocator.
I think rather $resourceOwnerMapLocator is a primary source for this.