Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore custom keys to be able to rewrite any default parameter. #903

Merged
merged 1 commit into from Nov 26, 2015
Merged

Ignore custom keys to be able to rewrite any default parameter. #903

merged 1 commit into from Nov 26, 2015

Conversation

ferrastas
Copy link
Contributor

Adding this flag, now are able to rewrite default parameters.\

For example, in HWI\Bundle\OAuthBundle\OAuth\ResourceOwner\GitHubResourceOwner there is a custom parameter emails_url that's not defined in the configuration tree builder. (Maybe other OAuth providers has another custom parameters)

Now, the GitHub Resource is fully compatible with GitHub Enterprise adding this in the main project config.yml

hwi_oauth:
    ...
    resource_owners:
        github:
            type:          github
            client_id:     %github.client_id%
            client_secret: %github.client_secret%
            authorization_url: %github.authorization_url%
            access_token_url: %github.access_token_url%
            revoke_token_url: %github.revoke_token_url%
            infos_url: %github.infos_url%
            emails_url: %github.emails_url%

@stloyd stloyd added the Bugfix label Nov 26, 2015
stloyd added a commit that referenced this pull request Nov 26, 2015
Ignore custom keys to be able to rewrite any default parameter.
@stloyd stloyd merged commit 023955d into hwi:master Nov 26, 2015
@stloyd
Copy link
Collaborator

stloyd commented Nov 26, 2015

Thanks!

@ferrastas ferrastas deleted the ignore-extra-params branch November 27, 2015 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants