-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warnings at compile time #176
Comments
Thank you for your alertness and reporting these warnings! These are false positives. The solution in ContextMap is not compiler-friendly, I have to admit. The compiler is confused by the fact that we are naming each of the 7 bytes in HashElementForContextMap independently (so they look like just 7 independent bytes) and at the same time we are transitioning from one to another with the p pointer (so we are treating the HashElementForContextMap as a 7-byte array). The warning is about this transition. We could make the warning disappear, if we'd have a 7-byte array in HashElementForContextMap, but then we wouldn't be able to clearly reference these state bytes independently (such as bitState and bitState0, bitState1, etc.) |
You could use constants for the names like |
Knowing these warnings are false positives is good! |
Yes, any compression level is good to use. Lower levels use less memory thus it can't remember patterns encounterd too far in the "past". It makes the modelling more adaptive. |
@L3P3 |
Is any of these warnings worrying?
The text was updated successfully, but these errors were encountered: