-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updates for new hooks in html-webpack-plugin #71
base: 3
Are you sure you want to change the base?
Conversation
631c8a8
to
1a82536
Compare
@hxlniada, hey i'd to help resolve any issues you have with this PR really need it. |
Is this project still maintained? Otherwise, would you like some new contributors so that they can maintain this? I really don't want to have to fork this. |
Id be happy to maintain this but i think a new package will have to be created |
@jaketodaro yep, me too. @hxlniada any thoughts? |
If this project is abandoned, I found another project which worked well for my use case: In my case I wanted it to output a manifest file using https://github.com/ztoben/assets-webpack-plugin. webpack-concat-plugin wouldn't play nice with assets-webpack-plugin as it didn't map the name to the manifest (only an empty string ""). Lucky for me webpack-merge-and-include-globally worked. |
I tried webpack-merge-and-include-globally and it works great for JS. Would just really like a simple solution of concat and sourcemaps for CSS. If anyone has suggestions, im all ears. |
Can confirm Sad that the maintainer completely abandoned this library, it would have been quite elegant for them to pass ownership to the community and the plugin would have been kept alive. |
I ran into this issue today after upgrading to the next version of weback-html-plugin.
#61
i left the old compiler options, this should be backwards compatible as i ran it with both versions of htmlWebpackPlugin, only the local decency version of webpack has to be the latest for this to work i guess, if that is true then the backwards compatibility will most likely not work.
Im not really sure if this will actually work unless the local version of html-webpack-plugin is upgraded aslo.
Perhaps we a conditional for the old compilation hooks. that might work.
Let me know what you think, this is my first time contributing to an open source project! :)