Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency Injection of database #3

Merged
merged 2 commits into from
Aug 3, 2018
Merged

Dependency Injection of database #3

merged 2 commits into from
Aug 3, 2018

Commits on Aug 3, 2018

  1. Dependency Injection of database 

    The object structure prior to this change did not make it easy to isolate the `StationGlobe` class, whether for testing or prefetching the database cache. I have separated it using dependency injection patterns.

NOTE: This breaks the initialization on L150. Waiting for @suclearnub to provide more information on the NOAA.module_db object scope to fix that
    @hxtk
    hxtk committed Aug 3, 2018
    Configuration menu
    Copy the full SHA
    96ac94d View commit details
    Browse the repository at this point in the history

  2. Dependency injection initialization 

    Fix initialization of the updated `StationGlobe` object from the previous commit.
Also I've moved the work into a method to eliminate import side effects.
    @hxtk
    hxtk committed Aug 3, 2018
    Configuration menu
    Copy the full SHA
    401063a View commit details
    Browse the repository at this point in the history