Added unittest for BaseServer.get_control_port

python-api/gstswitch/server.py

@@ -112,6 +112,12 @@ def get_control_port(self):
         :param: None
         :returns: Control port
         """
+        if type(self.CONTROL_PORT) != str:
+            raise TypeError("Control port: " + self.CONTROL_PORT + " should be a string")
+        try:
+            int(self.CONTROL_PORT)
+        except:
+            raise ValueError("Control port: " + self.CONTROL_PORT + " should have integral value")
         return self.CONTROL_PORT
 
     def get_record_file(self):

python-api/gstswitch/test_BaseServer.py

@@ -240,7 +240,7 @@ def test_normal(self):
         assert port == instance.get_video_port()
 
 
-class TestGetaudioPort(object):
+class TestGetAudioPort(object):
 
     def test_non_string(self):
         port = 1234
@@ -279,3 +279,44 @@ def test_normal(self):
         instance = BaseServer()
         instance.AUDIO_PORT = port
         assert port == instance.get_audio_port()
+
+
+class TestGetControlPort(object):
+
+    def test_non_string(self):
+        port = 1234
+        instance = BaseServer()
+        instance.CONTROL_PORT = port
+        with pytest.raises(TypeError):
+            res = instance.get_control_port()
+            assert res is None
+
+    def test_none(self):
+        port = None
+        instance = BaseServer()
+        instance.CONTROL_PORT = port
+        with pytest.raises(TypeError):
+            res = instance.get_control_port()
+            assert res is None
+
+    def test_zero_length_string(self):
+        port = ''
+        instance = BaseServer()
+        instance.CONTROL_PORT = port
+        with pytest.raises(ValueError):
+            res = instance.get_control_port()
+            assert res is None
+
+    def test_non_int_string(self):
+        port = 'abcd'
+        instance = BaseServer()
+        instance.CONTROL_PORT = port
+        with pytest.raises(ValueError):
+            res = instance.get_control_port()
+            assert res is None
+
+    def test_normal(self):
+        port = '3000'
+        instance = BaseServer()
+        instance.CONTROL_PORT = port
+        assert port == instance.get_control_port()