Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Logger #1138

Merged
merged 2 commits into from Feb 10, 2020
Merged

Fix for Logger #1138

merged 2 commits into from Feb 10, 2020

Conversation

artxneo
Copy link
Contributor

@artxneo artxneo commented Jan 23, 2020

Q                       A
Fixed Issues?
Patch: Bug Fix? Fix for logger
Major: Breaking Change?
Minor: New Feature?

Since Logger initialization evoke during AbstractAdapter __construct ,
we need transfer config['debug_mode'] and config['debug_file'] to the provider, thereby transfer them AbstractAdapter __construct

artxneo and others added 2 commits January 23, 2020 15:09
@artxneo
Fix for Logger
7fb7d31 
Since Logger initialization evoke during AbstractAdapter __construct ,
we need transfer config['debug_mode'] and config['debug_file'] to the provider, thereby transfer them AbstractAdapter __construct
@ApacheEx
Code style fixes
09bf22c
ApacheEx
ApacheEx approved these changes Feb 10, 2020
View reviewed changes
Copy link
Member

@ApacheEx ApacheEx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some code styles fixes. Thanks.

@ApacheEx ApacheEx added this to the 3.2 milestone Feb 10, 2020
@ApacheEx ApacheEx merged commit 43ced2b into hybridauth:master Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ApacheEx ApacheEx ApacheEx approved these changes

Assignees
No one assigned
Labels
tag: enhancement 💯
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@artxneo @ApacheEx