Add provider for OpenStreetMap, using OAuth 1.0a #869
Conversation
|
Thank you! Can I ask you to also provide basic documentation? |
|
Hum, I don't see where I should add basic documentation on this provider.
Can you provide an example of a provider that has this kind of documentation ?
|
| function getUserProfile() | ||
| { | ||
| try{ | ||
| $apiUrl = 'https://api.openstreetmap.org/api/0.6/user/details'; |
There was a problem hiding this comment.
can be just 'user/details' because $this->api->api_base_url will be added automatically.
There was a problem hiding this comment.
That's true - I've add several issue when making this provider, so I tried several things. The real fix was in fact to switch to a XML decoder instead of using json (which seems to be the default decoding)
| /** | ||
| * Hybrid_Providers_OpenStreetMap (openstreetmap.org) | ||
| */ | ||
| class Hybrid_Providers_OpenStreetMap extends Hybrid_Provider_Model_OAuth1 |
There was a problem hiding this comment.
there are no coding standards at all. Can you fix it according to PSR2 standard?
There was a problem hiding this comment.
Thanks, I've fixed indentation, and functions calls
| return $this->user->profile; | ||
| } | ||
|
|
||
| function httpRequest( $url ) |
There was a problem hiding this comment.
this is not used at all. Please remove.
There was a problem hiding this comment.
I've removed this unused function httpRequest().
|
|
||
| $response = @ new SimpleXMLElement( $response ); | ||
|
|
||
| $this->user->profile->identifier = (string) $response->user["id"]; |
There was a problem hiding this comment.
it's impossible to have object and array in one instance like here $response->user, so pls use only array style or only object-properties style.
There was a problem hiding this comment.
I don't quite understand what you mean ?
Should I replace $response->user["id"] by $response->user->id ?
|
Do you have any example of unit tests for Providers ? |
|
This is v2 so we can skip that part :( |
|
@ApacheEx Looking good now? |
Summary
Goal
Addition of OpenStreetMap authentication against v2 branch
Description
I've added OpenStreetMap authentication on wordpress plugin, and thought it would be better to add it on hybridauth git repository instead of wordpress-social-login. I've only tested the plugin through Wordpress.