Fix writing to servos #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where the pulse width for a servo would be too large an cause it to stall out. This was because the pulse width was not being caused by a percentage of the total number of degrees, but instead using the total number of degrees. The number of degrees as 180 has been determined based on testing where it was discovered that 180 degrees is typically the maximum angle for a servo. Originally noted in hybridgroup@122ff58#commitcomment-10680946. Signed-off-by: Kevin Brown <kevin@kevinbrown.in>
|
Closing this off as this is actually handled by Side note: There don't appear to be any tests for servos, and this PR was green at one point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with the equation used to calculate the pulse width, where the full number of degrees was being used instead of a percentage.