Possible issue with multiple devices using the same driver

[peterhellberg]

Configured devices

Cylon.robot
  devices:
    [
      { name: 'green', pin: 12, driver: 'led' },
      { name: 'red', pin: 7, driver: 'led' }
    ]

Log output

Starting devices...
Starting device 'green' on pin 12
LED on pin 12 started
Starting device 'red' on pin 7
LED on pin 12 started

Problem

Only the first LED is initialized, if I reorder the lines, then the other LED is initialized instead.

[peterhellberg]

Update

I wrote a (quite ugly) hack where I’m using the combined key driverName + opts.pin and it seems to be working for now. Is there a reason why each device loads the driver?

Key in Robot.prototype.requireDriver

this.robot.drivers[driverName + opts.pin]

[deadprogram]

Each device is supposed to create an associated driver object of that type. However, I see some errors in how this is currently implemented. We will look into it in bit, thanks for reporting it!

[peterhellberg]

Yes, it makes sense that each device has an instance of the driver. However, the driver probably shouldn’t need to be aware of the pin number, right?

Thank you for building all these frameworks, they made for a fun hackday project :)

[deadprogram]

I believe the code in the https://github.com/hybridgroup/cylon/tree/correct-driver-arch branch should correct your issue, if you want to give it a try, @peterhellberg

[peterhellberg]

Yes, I installed the code from the correct-driver-arch branch, and that did the trick.

This code is now doing what it should:

require('cylon').robot
  connection:
    name: 'arduino', adaptor: 'firmata', port: '/dev/cu.usbmodem1411'

  devices:
    [
      { name: 'red',   pin: 11, driver: 'led' },
      { name: 'green', pin: 10, driver: 'led' }
    ]

  work: (my) ->
    every 1.second(), -> my.red.toggle()
    every 2.second(), -> my.green.toggle()

.start()