Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for Dualsense joystick (PlayStation 5) #821

Closed
wants to merge 89 commits into from
Closed

Added support for Dualsense joystick (PlayStation 5) #821

wants to merge 89 commits into from

Conversation

jig
Copy link
Contributor

@jig jig commented May 29, 2022

Added support for PlayStation 5 Dualsense joystick.

Code derived from Dualshock 4:

  • buttons remapped to appropriate IDs
  • L2 and R2 are now "axis" instead of "buttons"
  • New "create" button (instead of "share" button)
  • examples/joystick_ps5.go file as example code

@jig jig marked this pull request as ready for review May 29, 2022 11:14
@jig jig changed the title Feature/dualsense Added support for Dualsense joystick (PlayStation 5) May 29, 2022
@jig jig marked this pull request as draft May 29, 2022 11:35
@jig
Copy link
Contributor Author

jig commented May 29, 2022

Example is being build. It has not to. Fixing it now.

@jig
Copy link
Contributor Author

jig commented May 29, 2022

Example building is disabled now.

@jig jig marked this pull request as ready for review May 29, 2022 11:43
@gen2thomas
Copy link
Collaborator

@jig unfortunatelly I have no such platform and device to test the new driver, but from the code review perspective, it looks good to me.

@deadprogram is there anything for you, what is against the merge?

gen2thomas and others added 17 commits September 24, 2022 13:52
@gen2thomas @deadprogram
BUGFIX: new pwm behaviour of tinkerboard
f141a2b
@gen2thomas @deadprogram
switch to golang 1.19 and to new cimg
3b68fee
@gen2thomas
BUGFIX: new home path for cimg
c89c88e
@gen2thomas
Merge pull request #853 from gen2thomas/fix/circleci_issue849
daa03ab 
BUGFIX: circleci new home path
now the basic changes are the same like #837
@deadprogram
test: increase some timings to make tests a little less fragile
ec29959 
Signed-off-by: deadprogram <ron@hybridgroup.com>
@gen2thomas
Merge pull request #854 from hybridgroup/test_utis_less_fragile
8640dd3 
test: make some tests less fragile
@gen2thomas
add unused but missing interface implementation for PiBlaster
4785804
@gen2thomas
fix PWM related read/write tests
5977c05
@gen2thomas
fix keyboard tests and exclude opencv
27b9e04
@MrARM @deadprogram
Add diagonal hat directions
14c3bde 
Diagonal directions are simply the 2 buttons hit added. 
Tested on a PowerA Xbox controller
@MrARM @deadprogram
Add definitions to controller class too
2588b58 
Website documentation did not make this immediately obvious
@gen2thomas
Merge pull request #855 from gen2thomas/fix/tests_issue852
dcf7f4d 
BUGFIX: some failing tests and implement unused interface
@gen2thomas
add tests of more platforms to CI
9b9df60
@gen2thomas
Merge pull request #857 from gen2thomas/feature/add_platforms_to_ci
5bbcfec 
add more platform tests to CI/CD
@st-user @deadprogram
Dji Tello Halt does not terminate all the related goroutines and may …
3c8f48a 
…wait forever when it is called multiple times

Add failing unit tests.
@st-user @deadprogram
Dji Tello Halt does not terminate all the related goroutines and may …
b07a272 
…wait forever when it is called multiple times

Fix the issue.
@st-user @deadprogram
Dji Tello Halt does not terminate all the related goroutines and may …
11259d4 
…wait forever when it is called multiple times

Fix the test for Halt method so that it waits for all the related goroutines to complete.
@gen2thomas
Copy link
Collaborator

gen2thomas commented Oct 20, 2022 •
edited
Loading

Hi @jig, please can you change the target branch to dev. Meanwhile I set it back to draft.

@gen2thomas gen2thomas marked this pull request as draft October 20, 2022 06:46
dlstjq7685 and others added 22 commits October 20, 2022 23:51
@dlstjq7685
Merge branch 'dev' into feature/jetson-nano-adaptor
8615079
@gen2thomas
GrovePi add read firmware version and DHT sensors
dd8a49c
@gen2thomas
GrovePi: add read firmware version and DHT sensors
75a146e
@gen2thomas
Joystick add Xbox-One controller
65d06fc
@gen2thomas
Joystick add Xbox-One controller
d827c91 
Joystick add Xbox-One controller
@gen2thomas
add PR template
ccadf3a
fix jetson nano pwm feature
83b0e28
@gen2thomas
i2c PCF8583 clock and counter driver introduced
9d1fd13
@gen2thomas
Add driver for PCF8583 clock and counter
ddf5227
little fix
ee0bff5
change JSBlasterPeriod to pwmDefaultPeriod
b04ecaa
@dlstjq7685 @gen2thomas
change const name.
84e54a4 
Co-authored-by: Thomas Kohler <g2t@e.mail.de>
@dlstjq7685 @gen2thomas
change args name
99ca267 
Co-authored-by: Thomas Kohler <g2t@e.mail.de>
fix inner func
d0dc2d9
@gen2thomas
Add Jetson Nano adpator
b3a3564
@gen2thomas
Jetson nano add missing SetPolarity
d97ac0b
@gen2thomas
Jetson nano add missing SetPolarity
5098f71
@gen2thomas
skip test TestNatsAdaptorFailedConnect when flaky
7f9d1a5
@gen2thomas
skip test TestNatsAdaptorFailedConnect when flaky
922977e
@gen2thomas
stabilize flaky utils_test
80e9d44
@gen2thomas
stabilize flaky utils_test
11bc499
@jig
Merged dev changes
4dd8ca9
@jig
Copy link
Contributor Author

jig commented Oct 25, 2022 •
edited
Loading

Hmm, I think I messed the history of this PR @gen2thomas trying to get changes from dev.
I'll try to redo this from scratch and I'll try to create a brand new (and hopefully correct PR).

I will close this PR when I will complete the new one.

@jig jig closed this by deleting the head repository Oct 29, 2022
@jig jig mentioned this pull request Oct 29, 2022
Merged
@jig
Copy link
Contributor Author

jig commented Oct 29, 2022

This PR has been superseded by #880.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jig @gen2thomas @dlstjq7685 @deadprogram @MrARM @st-user @orsinium