Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize doneCh in Tello NewDriverWithIP #931

Merged
merged 2 commits into from
Jun 11, 2023

Conversation

joeyberkovitz
Copy link
Contributor

Partially resolves #793

@gen2thomas
Copy link
Collaborator

Hi @joeyberkovitz , thanks for preparation of the PR. Currently we are fighting with the download problem of gobot framework since v2+, so please be patient. No action is required, also no rebase at the moment.

After that phase I will have a look to your change.

Thank you for your patience!

@gen2thomas gen2thomas self-requested a review May 28, 2023 17:43
@gen2thomas
Copy link
Collaborator

Hi @joeyberkovitz , we have fixed our issue without creating this "v2" subfolder. So please rebase your change.

Thanks, Thomas

@gen2thomas gen2thomas merged commit d9061ce into hybridgroup:dev Jun 11, 2023
1 check passed
@gen2thomas
Copy link
Collaborator

Hi @joeyberkovitz , thanks for your work, now merged.

gen2thomas pushed a commit to gen2thomas/gobot that referenced this pull request Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants