Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system(syscall): switch to x/sys #963

Merged
merged 2 commits into from
Jun 19, 2023

Conversation

gen2thomas
Copy link
Collaborator

@gen2thomas gen2thomas commented Jun 19, 2023

Solved issues and/or description of the change

If needed, a windows syscall (syscall_windows.go) can now be implemented without affecting the driver code. This is not done yet, because we use syscall for I2C drivers only and depend on Linux Kernel.

Manual test

  • Linux: armbian
  • Adaptor(s) and/or driver(s): Tinkerboard with PCA9533 (i2c test)

Checklist

  • The PR's target branch is 'hybridgroup:dev'
  • New and existing unit tests pass locally with my changes (e.g. by run make test)
  • No linter errors exist locally (e.g. by run make fmt_check)
  • I have performed a self-review of my own code

@gen2thomas gen2thomas marked this pull request as ready for review June 19, 2023 13:59
@gen2thomas
Copy link
Collaborator Author

Going to merge without further review, because all tests passed and a manual test for i2c is working.

@gen2thomas gen2thomas merged commit ad12eac into hybridgroup:dev Jun 19, 2023
1 check passed
@gen2thomas gen2thomas deleted the feature/x_sys branch June 19, 2023 14:06
gen2thomas added a commit to gen2thomas/gobot that referenced this pull request Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant