Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add BlobFromImages #467

Merged
merged 4 commits into from Jun 13, 2019
Merged

Conversation

WendelHime
Copy link
Contributor

Hi guys, I'm trying to implement the #395 , someone can please review and make suggestions?

@codecov-io
Copy link

codecov-io commented Jun 12, 2019

Codecov Report

Merging #467 into dev will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #467      +/-   ##
==========================================
+ Coverage   97.96%   97.98%   +0.01%     
==========================================
  Files          17       17              
  Lines        1968     1984      +16     
==========================================
+ Hits         1928     1944      +16     
  Misses         33       33              
  Partials        7        7
Impacted Files Coverage Δ
dnn.go 89.74% <100%> (+1.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c85a91...e72aec1. Read the comment docs.

@WendelHime
Copy link
Contributor Author

@deadprogram should I refactor blobFromImage to follow the opencv 4.1 specification?

@deadprogram
Copy link
Member

There are 2 signatures as that function is overloaded and we already have implemented one of them. There is has been no change in that version, so the answer would be "no, that is not needed".

@deadprogram
Copy link
Member

Also, thank you for the contribution! Now squashing/merging.

Thanks again!

@deadprogram deadprogram merged commit 55da81e into hybridgroup:dev Jun 13, 2019
acharyab15 pushed a commit to acharyab15/gocv that referenced this pull request Jul 8, 2019
* dnn: add BlobFromImages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants