Craft 5 #30
Merged
Craft 5 #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply fixes from StyleCI
Open
|
Thanks @janhenckens we'll take a look and thank you for the help on this one 🎉 We should be able to get to this later this or next week |
|
Any update on this? Fantastic plugin. Would love it for Craft 5 too. |
|
The scrutinizer error is due to the settings of your test environment not matching Craft 5 requirements. I’m currently building a site that would greatly benefit from this visual solution instead of a boring menu list, please do the merge :) |
DynamiteGoesBoom
merged commit 779e6e0
into
hybridinteractive:master
1 of 2 checks passed
|
Fantastic thanks for this. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the few changes needed for Craft 5.
Not sure how you want to handle branching between versions so I made the PR against master for now.