fix(define): keep lastValue for HMR update

hybridsjs · May 5, 2021 · bdff4c0 · bdff4c0
1 parent c155fed
commit bdff4c0
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/src/define.js b/src/define.js
@@ -96,14 +96,18 @@ function update(Hybrid, lastHybrids) {
     deferred.then(() => {
       walkInShadow(document.body, node => {
         if (updateQueue.has(node.constructor)) {
-          const hybrids = updateQueue.get(node.constructor);
+          const prevHybrids = updateQueue.get(node.constructor);
+          const hybrids = node.constructor.hybrids;
           node.disconnectedCallback();
 
-          Object.keys(node.constructor.hybrids).forEach(key => {
+          Object.keys(hybrids).forEach(key => {
+            const type = typeof hybrids[key];
             cache.invalidate(
               node,
               key,
-              node.constructor.hybrids[key] !== hybrids[key],
+              type !== "object" &&
+                type !== "function" &&
+                hybrids[key] !== prevHybrids[key],
             );
           });