Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing error message #54

Merged
merged 1 commit into from Jun 8, 2019
Merged

Fixing error message #54

merged 1 commit into from Jun 8, 2019

Conversation

awei01
Copy link
Contributor

@awei01 awei01 commented Jun 7, 2019

Looks like we're referencing an undeclared variable v and will always print out Assigned value must be an object: undefined

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 8c0d25a on awei01:patch-1 into ed7ba14 on hybridsjs:master.

smalluban
smalluban approved these changes Jun 8, 2019
View reviewed changes
Copy link
Contributor

@smalluban smalluban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! The issue is not critical, so I release it within the next changes.

@smalluban smalluban merged commit 92f7939 into hybridsjs:master Jun 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smalluban smalluban smalluban approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@awei01 @coveralls @smalluban