Transform boolean attribute values to preserve reasonable values. #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case of a Hybrids element property with a default value of 'true', any attempt to make the property false by passing an attribute value of 'false' failed. Instead of passing boolean attribute values through the Boolean constructor, this change passes 'true' and 'false' values through JSON.parse() to avoid confusing during attribute assignment to properties. --- Related Issue: hybridsjs#92
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit cbad40c:
|
|
Closing, as I explained in #92. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case of a Hybrids element property with a default value of 'true', any attempt to make the property false by passing an attribute value of 'false' failed.
Instead of passing boolean attribute values through the Boolean constructor, this change passes 'true' and 'false' values through JSON.parse() to avoid confusing during attribute assignment to properties.
If you'd prefer a different approach than the one described in this PR or have some workaround in mind, by all means, feel free to reject it. 馃槃
You should know that I had some trouble getting the tests to run on my machine and so I've made the modifications to the spec file blindly. If all looks good, you should at least pull the branch down and run the test in case I've fat-fingered something there.
Related Issue: #92