Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused import/function in the recent release #281

Closed
orhun opened this issue Jul 26, 2023 · 3 comments
Closed

Unused import/function in the recent release #281

orhun opened this issue Jul 26, 2023 · 3 comments

Comments

@orhun
Copy link
Contributor

orhun commented Jul 26, 2023

Hello! 🐻

While updating the AUR package for hoard, I realized there are a couple of unused things:

warning: unused import: `DrawState`
 --> src/gui/list_search/key_not_set_controls.rs:2:46
  |
2 | use crate::gui::commands_gui::{ControlState, DrawState, State};
  |                                              ^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default

warning: unused import: `chatgpt::prelude::ChatGPT`
  --> src/hoard.rs:27:5
   |
27 | use chatgpt::prelude::ChatGPT;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^

warning: associated function `from_gpt_string` is never used
   --> src/command/hoard_command.rs:244:12
    |
18  | impl HoardCommand {
    | ----------------- associated function in this implementation
...
244 |     pub fn from_gpt_string(gpt_string: &str) -> Self {
    |            ^^^^^^^^^^^^^^^
    |
    = note: `#[warn(dead_code)]` on by default

warning: `hoard-rs` (bin "hoard") generated 3 warnings (run `cargo fix --bin "hoard"` to apply 2 suggestions)

Just wanted to ask if they are a part of an incomplete implementation or left there on purpose. I might submit a PR to remove the warnings if needed.

Thank you!

@Hyde46
Copy link
Owner

Hyde46 commented Jul 28, 2023

Thanks for the issue!
I hastily put the release together which i shouldn't have, i'll fix it in the coming days 😃

@Hyde46
Copy link
Owner

Hyde46 commented Jul 29, 2023

Fixed in #282

@Hyde46 Hyde46 closed this as completed Jul 29, 2023
@orhun
Copy link
Contributor Author

orhun commented Jul 29, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants