Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty default values for dialoguer result in empty commands #48

Closed
Hyde46 opened this issue Oct 6, 2021 · 0 comments
Closed

Empty default values for dialoguer result in empty commands #48

Hyde46 opened this issue Oct 6, 2021 · 0 comments
Labels
🐛 bug Something isn't working 🌟 good first issue Good for newcomers

Comments

@Hyde46
Copy link
Owner

Hyde46 commented Oct 6, 2021

See here for example.
This is true for all with_<x>_input() methods.
The idea is to allow supplying Option<String> for a default prompt.
However, currently if the default prompt is None, the default prompt from dialoguer is an empty string.

To fix this:
only add .default() to the Input object if the default_value is Some

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working 🌟 good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant