Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermittent double render #42

Closed
woahdae opened this issue Oct 25, 2017 · 1 comment
Closed

Intermittent double render #42

woahdae opened this issue Oct 25, 2017 · 1 comment

Comments

@woahdae
Copy link

@woahdae woahdae commented Oct 25, 2017

I can't quite pin down exactly when this happens. I've seen it on new page loads with no browser cache, but sometimes new page loads seem to work OK. Most easily reproduced on Safari because Chrome only lets you disable cache with the developer tools open, which can trigger their own weird behaviors. Here's a repro video.

Also, would it be easy to turn off the fade down animation? I personally find it distracting, and as a bonus you wouldn't notice the double render as much.

@qwtel
Copy link
Member

@qwtel qwtel commented Oct 26, 2017

thanks for making this repro video!

okay that took some time to unravel. basically the problem is that these pages are located in /assets, and links to it are never intercepted by JS (because they are usually links to images, downloads, etc, not Jekyll pages).

Fresh page loads have a CSS fade-in animation, which mimics the JS animation. When the page is served from cache, it almost looks as if the page was loaded dynamically, because webfonts etc are already applied. Otherwise there is "flickering", as the webfont is applied...

The real question is how pages from the assets folder ended up among Jekyll's pages. Turns out they are actually the README.md files for two bower components. I suspect this has to do with building the site on GitHub pages. Apparently, the jekyll-readme-index plugin is enabled there, even when it's not included in the list of plugins in the config file. When I check out your repo and build it locally it works fine (so following these build steps should work)

Anyway, in the next release I'm going to delete all *.md files in the assets folder which should get rid of this as well.

@qwtel qwtel closed this as completed Oct 26, 2017
qwtel added a commit that referenced this issue Oct 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants