Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where DocumentationPage::home() did not work when the documentation page output directory is customized #385

Conversation

caendesilva
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #385 (adc4536) into master (ff1052d) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##              master      #385   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
+ Complexity       885       884    -1     
===========================================
  Files             97        97           
  Lines           2172      2171    -1     
===========================================
- Hits            2172      2171    -1     
Impacted Files Coverage Δ
...s/framework/src/Models/Pages/DocumentationPage.php 100.00% <100.00%> (ø)
...ctions/Constructors/FindsNavigationDataForPage.php 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva merged commit 027b7af into master Aug 8, 2022
@caendesilva caendesilva deleted the 382-documentationpagehome-does-not-seem-to-work-for-customized-nested-docs-output-paths branch August 8, 2022 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DocumentationPage::home() does not seem to work for customized (nested) docs output paths
2 participants