Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spatie YAML Front Matter Package not properly handling Markdown documents with Markdown inside #36

Closed
caendesilva opened this issue Mar 28, 2022 · 3 comments · Fixed by #79
Closed

Spatie YAML Front Matter Package not properly handling Markdown documents with Markdown inside #36

caendesilva opened this issue Mar 28, 2022 · 3 comments · Fixed by #79
Assignees
@caendesilva

Comments

@caendesilva
Copy link
Member

Switching to the aforementioned package has caused some examples to break, more specifically, where Markdown examples were used in Markdown files. This bug is documented in spatie/yaml-front-matter#30.
@caendesilva
Copy link
Member Author

Looking into this. Think I will fork it for now.

@caendesilva caendesilva self-assigned this Mar 30, 2022
@caendesilva
Copy link
Member Author

Submitted a PR to fix this, spatie/yaml-front-matter#38. Awaiting response.

@caendesilva
Copy link
Member Author

The fix has been merged to the package main. Creating a PR to bump the version on our end.

@caendesilva caendesilva linked a pull request Apr 8, 2022 that will close this issue
Update Spatie YAML Front Matter Package to fix #36 #79
Merged
caendesilva added a commit that referenced this issue Apr 8, 2022
@caendesilva
Merge pull request #79 from hydephp/36-spatie-yaml-front-matter-packa…
04eb7da 
…ge-not-properly-handling-markdown-documents-with-markdown-inside

Update Spatie YAML Front Matter Package to fix #36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caendesilva caendesilva

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Spatie YAML Front Matter Package to fix #36 hydephp/framework
1 participant
@caendesilva