Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit test for prettier command #363

Closed
caendesilva opened this issue May 16, 2022 · 1 comment
Closed

Add unit test for prettier command #363

caendesilva opened this issue May 16, 2022 · 1 comment

Comments

@caendesilva
Copy link
Member 

     * @todo Add unit test for prettier command (can work by comparing compiled baseline to output to see if it was prettified);

framework/src/Commands/HydeBuildStaticSiteCommand.php

Line 149 in aca438d

*

Can work by comparing compiled baseline to output to see if it was prettified
caendesilva added a commit that referenced this issue May 16, 2022
@caendesilva
Add todo #363
ef444b8
@caendesilva
Copy link
Member Author

Actually, not doing this as it will require test runners to install NPM deps which feels unnecessary for a unit test.

caendesilva pushed a commit that referenced this issue Aug 7, 2022
Merge pull request #363 from hydephp/code-cleanup
f2355a6 
Minor code cleanups and fixes hydephp/develop@8ab35d5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@caendesilva