Merge pull request #83 from latera/HOMS-163

HOMS-163 Fix filtering orders when filter by user name is not set

config/locales/en.yml

@@ -249,7 +249,7 @@ en:
     'yes': Yes
     not_selected: Not selected
     select2:
-      not_set: Not set
+      not_set: Empty
     user_not_found: Current user not found in Activiti
 
   doc:

lib/imprint/services/order_printing_service.rb

@@ -18,10 +18,6 @@ class OrderPrintingService
         optional(:filter).maybe(:str?)
         optional(:user_id).maybe(:array?)
 
-        rule(filter_only: [:filter, :user_id]) do |filter, user_id|
-          filter.filled? > user_id.filled?
-        end
-
         rule(order_type_for_custom_fields: [:order_type_id, :custom_fields]) do |order_type_id, custom_fields|
           custom_fields.filled?.then(order_type_id.filled?)
         end

spec/features/orders/list_orders_spec.rb

@@ -147,6 +147,11 @@
     select2_cross('user_id[]', 'Empty').click
     search_button.click
     expect(empty_order_list).not_to eq(nil)
+
+    # Filter by user name isn't set
+    select2_cross('user_id[]', 'Christopher Johnson').click
+    search_button.click
+    expect(orders_list).to eq(current_orders_list)
   end
 
   scenario 'with filter by custom fields' do