[columnar] Fix corruption possibilities for vacuum UDF #190
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this should fix #169.
there are two parts to the vacuum UDF:
bailing out in the combination process is not an issue, but bailing out during the reorganization is. if we exit cleanly from the signal handlers, instead of calling the signal after we feel we are safe, we do not have corruption. unfortunately, not calling the signal that we blocked is not an acceptable solution.
interestingly, finishing a single reorganization does not corrupt, even if the signal handlers are called. this PR sets up the vacuum UDF to do a singular reorganization, renames the UDF to
columnar._vacuum_internal
, and creates a newcolumnar.vacuum
that recreates the original functionality by continually calling thecolumnar._vacuum_internal
either until done, or we reach the optional count.this does add additional time to the UDF.
note that this does increase the version of columnar, so we will need to upgrade the extension to fully fix the problem.