Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ru language #671

Merged
merged 7 commits into from
Jun 28, 2024
Merged

Fix ru language #671

merged 7 commits into from
Jun 28, 2024

Conversation

CMAULTOP
Copy link
Contributor

No description provided.

@svensken94
Copy link

Hi! There are translation errors. Why did you translate "behavior" as "Windows settings"?
Launcher is not created only for Windows.

Copy link

@ScoobyShurik ScoobyShurik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammary errors

src/locales/ru/translation.json Outdated Show resolved Hide resolved
src/locales/ru/translation.json Outdated Show resolved Hide resolved
@svensken94
Copy link

Перед "вместо" запятая не нужна и можно убрать "полностью" в принципе

@zamitto
Copy link
Collaborator

zamitto commented Jun 28, 2024

@svensken94 @ScoobyShurik do you want to review it again? We are releasing a new version today

@svensken94
Copy link

@svensken94 @ScoobyShurik do you want to review it again? We are releasing a new version today

There are still some errors in the commit. I can't review, but I can see that there are errors.

@zamitto
Copy link
Collaborator

zamitto commented Jun 28, 2024

@svensken94 I can edit his PR if you tell me what to change

@svensken94
Copy link

"quit_app_instead_hiding": "Закрывать приложение вместо сворачивания в трей", // new changes (line 156)
"behavior": "Поведение", // need to revert changes to 'Поведение' (line 159)

I actually have a lot of questions about the existence of this pull request, but why not.

@CMAULTOP
Copy link
Contributor Author

What was the point of changing back to behavior if it sounds as strange as possible in Russian and the stylistic type is definitely violated

@zamitto
Copy link
Collaborator

zamitto commented Jun 28, 2024

What was the point of changing back to behavior if it sounds as strange as possible in Russian and the stylistic type is definitely violated

I think I'm going to soon approve this PR as it as right now, but if you wanna to keep discussing what you think is the best way, feel free to open another PR.

@zamitto zamitto merged commit 0eaf629 into hydralauncher:main Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants