Directive to Split Email Address into Account and Domain #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russorat
reviewed
Feb 2, 2017
| String[] parts = ((String) object).split("@"); | ||
| if (parts.length > 1) { | ||
| record.add(column + ".account", parts[0]); | ||
| record.add(column + ".domain", StringUtils.join(ArrayUtils.subarray(parts, 1, parts.length), "@")); |
There was a problem hiding this comment.
i think this is actually backwards. you want to use the last "part" as the domain (since it can't contain additional @ symbols) and join all the first parts as the account. http://stackoverflow.com/a/36297137
russorat
reviewed
Feb 2, 2017
| List<Record> records = Arrays.asList( | ||
| new Record("email", "root@cask.co"), | ||
| new Record("email", "joltie.xxx@gmail.com"), | ||
| new Record("email", "joltie_xxx@hotmail.com") |
There was a problem hiding this comment.
can you add a test for an email that looks like this: a."b@c".d@e.f after you fix the parsing above?
russorat
reviewed
Feb 2, 2017
| Assert.assertNotNull(records.get(0).getValue("email.domain")); | ||
| Assert.assertEquals("root.hotmail.com", records.get(1).getValue("email.account")); | ||
| } | ||
| } |
added 2 commits
February 2, 2017 12:30
…rangler into feature/directive-email-split
russorat
reviewed
Feb 2, 2017
| } | ||
| if (object instanceof String) { | ||
| String emailAddress = (String) object; | ||
| int nameIdx = emailAddress.lastIndexOf("<"); // Joltie, Root <joltie.root@yahoo.com> |
There was a problem hiding this comment.
should you have an option to store the "display name" along with account and domain? could also be a future enhancement
There was a problem hiding this comment.
It will be a separate directive to extract that.
russorat
reviewed
Feb 2, 2017
| Assert.assertNotNull(records.get(0).getValue("email.domain")); | ||
| Assert.assertNull(records.get(1).getValue("email.account")); | ||
| } | ||
| } |
|
minor comments. once those are addressed, LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Directive checklist