Skip to content
This repository has been archived by the owner on Aug 10, 2019. It is now read-only.

Fixes bugs in OSX dependency install #17

Merged
merged 2 commits into from
Sep 12, 2018
Merged

Fixes bugs in OSX dependency install #17

merged 2 commits into from
Sep 12, 2018

Conversation

vsreekanti
Copy link
Member

@vsreekanti vsreekanti commented Sep 10, 2018

Fixes #16 and addresses similar bugs in debian scripts.

@codecov
Copy link

codecov bot commented Sep 10, 2018

Codecov Report

Merging #17 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #17   +/-   ##
=======================================
  Coverage   62.72%   62.72%           
=======================================
  Files          50       50           
  Lines        1438     1438           
=======================================
  Hits          902      902           
  Misses        536      536

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 002b9a4...042f6e3. Read the comment docs.

andyli029 added a commit to andyli028/fluent that referenced this pull request Sep 11, 2018
Copy link
Contributor

@cw75 cw75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@cw75 cw75 merged commit 0ff703d into hydro-project:master Sep 12, 2018
@andyli029
Copy link

@cw75 andyli028@1b2261d
the pr is not merged?

@vsreekanti vsreekanti deleted the osx-script branch September 13, 2018 03:23
@vsreekanti
Copy link
Member Author

Hi @andyli029, it looks like the commit got overridden in the rebase by mistake, but the LCOV_VERSION line still exists, as you can see here. Sorry about the mistake!

@andyli029
Copy link

ok

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants