-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug info about demux_enum #1201
Labels
Comments
MingweiSamuel
added
bug
Something isn't working
hydroflow syntax
Hydroflow's custom surface syntax
debugging/observability
and removed
bug
Something isn't working
labels
May 17, 2024
MingweiSamuel
added a commit
to MingweiSamuel/hydroflow
that referenced
this issue
May 18, 2024
MingweiSamuel
added a commit
to MingweiSamuel/hydroflow
that referenced
this issue
May 18, 2024
Will simplify the implementation a bit. Hands a bit tied by the way macros work, but should be a bit better #1204 |
MingweiSamuel
added a commit
to MingweiSamuel/hydroflow
that referenced
this issue
May 18, 2024
MingweiSamuel
added a commit
to MingweiSamuel/hydroflow
that referenced
this issue
May 18, 2024
MingweiSamuel
added a commit
to MingweiSamuel/hydroflow
that referenced
this issue
May 20, 2024
MingweiSamuel
added a commit
that referenced
this issue
May 20, 2024
Can't really make the error messages perfect due to how proc macros work but they should be a lot better now. Feel free to post any weird error messages you get and we can see if it can be improved further |
Thanks a lot! It's indeed more readable now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi, we are a team from Carnegie Mellon University using Hydroflow for reactive programming. The idea Hydroflow representing code as dataflow is really inspiring and convenient for us to use. Thanks for your great project!
A slight issue we encounter is when we use the operator
demux_enum
, the debug info auto-generated by rust compiler is a bit confusing. For example, we didn't notice there's a requirement for exhaustive matching for succeeding dataflow ofdemux_enum
, while the error message is, for example:Another example is when succeeding dataflow's input type doesn't match
demux_enum
's output type, the error message refers todemux_enum
rather than succeeding dataflow, for example:We feel like maybe in future sprints, you can improve these bug reports to make Hydroflow more user friendly. Thanks!
The text was updated successfully, but these errors were encountered: