Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

having both sink_async and write_async is confusing for users #216

Closed
jhellerstein opened this issue Oct 18, 2022 · 2 comments
Closed

having both sink_async and write_async is confusing for users #216

jhellerstein opened this issue Oct 18, 2022 · 2 comments
Assignees
@MingweiSamuel
Labels
enhancement New feature or request hydroflow syntax Hydroflow's custom surface syntax
Milestone
0.1 release

Comments

@jhellerstein
Copy link
Contributor

are they meaningfully different? can we make it easier to understand? Else document better.
@MingweiSamuel MingweiSamuel self-assigned this Oct 18, 2022
@MingweiSamuel MingweiSamuel added enhancement New feature or request hydroflow syntax Hydroflow's custom surface syntax labels Oct 18, 2022
@MingweiSamuel
Copy link
Member

Added a bit of explanation in docs in #246

@MingweiSamuel MingweiSamuel added this to the 0.1 release milestone Dec 5, 2022
MingweiSamuel added a commit to MingweiSamuel/hydroflow that referenced this issue Dec 9, 2022
@MingweiSamuel
Add distinguishing notes for dest_asyncwrite vs dest_sink hydro-p…
db724a6 
…roject#216
MingweiSamuel added a commit to MingweiSamuel/hydroflow that referenced this issue Dec 9, 2022
@MingweiSamuel
Add distinguishing notes for dest_asyncwrite vs dest_sink hydro-p…
3c8e960 
…roject#216
@MingweiSamuel
Copy link
Member

Need doc examples for these two

@MingweiSamuel MingweiSamuel reopened this Dec 12, 2022
MingweiSamuel added a commit to MingweiSamuel/hydroflow that referenced this issue Dec 12, 2022
@MingweiSamuel
Add example usage code to dest_sink, dest_asyncwrite, hydro-proje…
4ce90b5 
…ct#216
MingweiSamuel added a commit to MingweiSamuel/hydroflow that referenced this issue Dec 12, 2022
@MingweiSamuel
Add example usage code to dest_sink, dest_asyncwrite, hydro-proje…
87fb64c 
…ct#216
MingweiSamuel added a commit to MingweiSamuel/hydroflow that referenced this issue Dec 14, 2022
@MingweiSamuel
Add example usage code to dest_sink, dest_asyncwrite, hydro-proje…
d6df3eb 
…ct#216
MingweiSamuel added a commit to MingweiSamuel/hydroflow that referenced this issue Dec 14, 2022
@MingweiSamuel
Remove dest_asyncwrite, consolidate using codecs, now in `hydroflow…
862b130 
…::util::udp/tcp`, fix hydro-project#216
MingweiSamuel added a commit to MingweiSamuel/hydroflow that referenced this issue Dec 14, 2022
@MingweiSamuel
Remove dest_asyncwrite, consolidate using codecs, now in `hydroflow…
223b85a 
…::util::udp/tcp`, fix hydro-project#216
MingweiSamuel added a commit to MingweiSamuel/hydroflow that referenced this issue Dec 15, 2022
@MingweiSamuel
Remove dest_asyncwrite, consolidate using codecs, now in `hydroflow…
3539ad3 
…::util::udp/tcp`, fix hydro-project#216
MingweiSamuel added a commit that referenced this issue Dec 15, 2022
@MingweiSamuel
Add example usage code to dest_sink, dest_asyncwrite, #216
05c990f
nickjiang2378 pushed a commit to nickjiang2378/hydroflow that referenced this issue Jan 24, 2024
@MingweiSamuel
Rename source and dest surface syntax operators, fix hydro-project#216 …
6d6860a 
…hydro-project#276 (hydro-project#284)

* surface: `recv_iter` -> `source_iter`

* surface: `recv_stream` -> `source_stream`

* surface: `recv_stdin` -> `source_stdin`

* surface: `recv_stream_serde` -> `source_stream_serde`

* surface `async_sink` -> `dest_sink`

* surface `async_sink_serde` -> `dest_sink_serde`

* surface `write_async` -> `dest_asyncwrite`

* Add distinguishing notes for `dest_asyncwrite` vs `dest_sink` hydro-project#216
nickjiang2378 pushed a commit to nickjiang2378/hydroflow that referenced this issue Jan 24, 2024
@MingweiSamuel
Add example usage code to dest_sink, dest_asyncwrite, hydro-proje…
e5848b6 
…ct#216
nickjiang2378 pushed a commit to nickjiang2378/hydroflow that referenced this issue Jan 24, 2024
@MingweiSamuel
Remove dest_asyncwrite, consolidate using codecs, now in `hydroflow…
4168ad3 
…::util::udp/tcp`, fix hydro-project#216
nickjiang2378 pushed a commit to nickjiang2378/hydroflow that referenced this issue Jan 25, 2024
@MingweiSamuel
Rename source and dest surface syntax operators, fix hydro-project#216 …
55dd69a 
…hydro-project#276 (hydro-project#284)

* surface: `recv_iter` -> `source_iter`

* surface: `recv_stream` -> `source_stream`

* surface: `recv_stdin` -> `source_stdin`

* surface: `recv_stream_serde` -> `source_stream_serde`

* surface `async_sink` -> `dest_sink`

* surface `async_sink_serde` -> `dest_sink_serde`

* surface `write_async` -> `dest_asyncwrite`

* Add distinguishing notes for `dest_asyncwrite` vs `dest_sink` hydro-project#216
nickjiang2378 pushed a commit to nickjiang2378/hydroflow that referenced this issue Jan 25, 2024
@MingweiSamuel
Add example usage code to dest_sink, dest_asyncwrite, hydro-proje…
f9ce37f 
…ct#216
nickjiang2378 pushed a commit to nickjiang2378/hydroflow that referenced this issue Jan 25, 2024
@MingweiSamuel
Remove dest_asyncwrite, consolidate using codecs, now in `hydroflow…
297c360 
…::util::udp/tcp`, fix hydro-project#216
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MingweiSamuel MingweiSamuel

Labels
enhancement New feature or request hydroflow syntax Hydroflow's custom surface syntax
Projects
None yet
Milestone
0.1 release
Development

No branches or pull requests
2 participants
@jhellerstein @MingweiSamuel