-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend Chat Example w/ Gossip Based Backend #1120
Conversation
Deploying hydroflow with
|
Latest commit: |
7271227
|
Status: | ✅ Deploy successful! |
Preview URL: | https://9126cf52.hydroflow.pages.dev |
Branch Preview URL: | https://rohit-randomized-gossip.hydroflow.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First thought is that it would be best to have separate regular vs gossip version of chat, what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Can you augment the README to discuss the different roles and how they work?
In one of the stand-ups, Joe suggested interop with the existing client as a goal. This seems like the easiest way to do that. What'd you have in mind? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, sounds good to me then
The current code supports letting readers see the distinction between single-server vs gossiping-server, and run either one from the command line. The README.md should talk that through in a bit more detail is all. |
This is done. The new readme can also be run straight from the IDE (at least IntelliJ at the moment, unsure what vscode does with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
575b4de
to
ffccdb5
Compare
Added a gossip-based backend for the chat example. The implementation is based on ["Epidemic algorithms for replicated database maintenance"](https://dl.acm.org/doi/epdf/10.1145/41840.41841). Specifically, it implements push-based "rumor-mongering" with a blind-coin removal process.
Also added a test for the gossip server.
05badc4
to
7271227
Compare
Only conventional commits didn't pass, so squashing and merging. Wondering if we should configure that check differently. |
Added a gossip-based backend for the chat example.
The implementation is based on "Epidemic algorithms for replicated database maintenance". Specifically, it implements push-based "rumor-mongering" with a blind-coin removal process.