Extract Rust predicate expression generation #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was about to put up a PR for this haha |
tylerhou
force-pushed
the
pr539
branch
5 times, most recently
from
d98c6f6
to
5dd7527
Compare
|
Rebased onto main. |
Also rename `test_simple_filter` to `test_simple_boolean_relation_filter` so it is easier to grep for where we use boolean relations in tests.
MingweiSamuel
force-pushed
the
main
branch
2 times, most recently
from
b0c3916
to
5d48544
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract Rust predicate expression generation
Also rename
test_simple_filtertotest_simple_boolean_relation_filterso itis easier to grep for where we use boolean relations in tests.